Fix not transforming logical assignments for packages#36484
Merged
Conversation
kevin940726
added
[Type] Bug
kevin940726
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
|
Size Change: +57 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Nov 15, 2021
noisysocks
left a comment
noisysocks
left a comment
Member
There was a problem hiding this comment.
It works! Not really sure why the core build process chokes when it sees ??= but Gutenberg's does not. We can investigate that more thoroughly later though.
noisysocks
force-pushed
the
fix/babel-build-logical-assignment
branch
from
f0ba7f9 to
870305e
Compare
noisysocks
force-pushed
the
fix/babel-build-logical-assignment
branch
from
870305e to
1739a51
Compare
noisysocks
pushed a commit
that referenced
this pull request
Nov 15, 2021
Member
|
I see that it fixes the issue in WP core. Let’s investigate options after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logical assignment operators in packages are not being transformed when building for production builds. It's only being surfaced in the recent babel upgrade (#36244). This breaks the builds in Core so we have to publish new builds to fix this.
How has this been tested?
npm run buildpackages/components/build-module/card/card/hook.js??=, there should be matches.Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).