Skip to content

Typography Panel: Make letter spacing jsDoc and prop use consistent #36367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 2 commits into from
Nov 15, 2021
Merged

Typography Panel: Make letter spacing jsDoc and prop use consistent #36367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c971d7d
Make jsdoc and unstableWidth prop use consistent for letter spacing c…
aaronrobertshaw Nov 10, 2021
85635f5
Improve approach
aaronrobertshaw Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/block-editor/src/components/letter-spacing-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ import useSetting from '../../components/use-setting';
/**
* Control for letter-spacing.
*
* @param {Object} props Component props.
* @param {string} props.value Currently selected letter-spacing.
* @param {Function} props.onChange Handles change in letter-spacing selection.
* @param {boolean} props.__unstableInputWidth Input width to pass through to inner UnitControl.
* @param {Object} props Component props.
* @param {string} props.value Currently selected letter-spacing.
* @param {Function} props.onChange Handles change in letter-spacing selection.
* @param {string|number|undefined} props.__unstableInputWidth Input width to pass through to inner UnitControl. Should be a valid CSS value.
*
* @return {WPElement} Letter-spacing control.
* @return {WPElement} Letter-spacing control.
*/
export default function LetterSpacingControl( {
value,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-editor/src/hooks/letter-spacing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function LetterSpacingEdit( props ) {
<LetterSpacingControl
value={ style?.typography?.letterSpacing }
onChange={ onChange }
__unstableInputWidth={ false }
__unstableInputWidth={ '100%' }
/>
);
}
Expand Down