Global Styles: generate preset metadata for font-family in the site editor#36022
Merged
Conversation
aaronrobertshaw
added
[Type] Bug
Contributor
Author
|
@oandregal I hope you don't mind the extra ping on this PR. I've had some trouble trying to follow the reasoning and decisions made around which styles or settings to include in the Site Editor. Given I'm missing a fair bit of context, I'm assuming the simplistic solution in this PR is missing some important consequences. I figure you're the best person to enlighten me and point me in the right direction. 🙏 |
aaronrobertshaw
changed the title
|
Size Change: +24 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
aaronrobertshaw
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
oandregal
approved these changes
Oct 28, 2021
oandregal
left a comment
oandregal
left a comment
Member
There was a problem hiding this comment.
Brilliant, this works nicely.
oandregal
changed the title
oandregal
added
the
[Feature] Site Editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36015
Description
This PR updates the
PRESET_METADATAconfig for font-family to allow appropriate CSS class generation for global styles and the site editor.How has this been tested?
Manually in Site Editor:
Screenshots
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).