Font Appearance: Improve consistency of label in Typography panel#35860
Merged
aaronrobertshaw merged 1 commit intoOct 25, 2021
Conversation
aaronrobertshaw
added
the
[Feature] Design Tools
|
Size Change: +23 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 24, 2021
ramonjd
left a comment
ramonjd
left a comment
Member
There was a problem hiding this comment.
Also LGTM!
The corresponding labels appear when single font/style controls are activated. When both are activated, I see "Appearance".
Also setting control defaults works as expected
andrewserong
approved these changes
Oct 24, 2021
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the follow-up @aaronrobertshaw! I tested with the Heading and Navigation blocks that the Font Weight and Appearance labels are now consistent. Then, manually switched the Heading block over to use __experimentalFontStyle instead, and confirmed that the Font Style label appears correctly.
LGTM!
aaronrobertshaw
deleted the
update/appearance-label-in-typography-panel
branch
andrewserong
added
the
[Type] Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Description
This PR makes the label within the Typography panel's menu for font appearance consistent with the label displayed within the control itself.
When both font styles and weights are present and supported the label will read "Appearance". When only font styles are preset it will read "Font styles" and likewise "Font weights" when only font-weight is supported. If nothing is supported the control/item isn't added to the panel.
See: #33744 (comment)
How has this been tested?
Manually.
ToolsPanelmenuScreenshots
Screen.Recording.2021-10-22.at.3.44.26.pm.mp4
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).