Page List: Show empty placeholder if no items#35441
Merged
Merged
Conversation
Member
Author
|
@jasmussen I use just the default |
|
Size Change: +2.2 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Oct 8, 2021
tellthemachines
left a comment
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Just a minor comment below, but not a blocker.
| // Return early and empty to trigger EmptyResponsePlaceholder. | ||
| if ( empty( $top_level_pages ) ) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
We could return even earlier if we instead checked $all_pages above.
Contributor
|
Nice one! Before: After:
The first is the page list inside navigation, the second is just a standalone page list. I also confirmed that the placeholder is only shown in the editor. However, in light of what we're doing to other FSE blocks (see #35243 and #35242), I think we should avoid the use of the Removing the placeholder could make it look like this: This is the markup I inspected myself to:
|
This makes it more clear and bails out even earlier.
Member
Author
|
Thanks @tellthemachines good catch, I moved the check up even earlier, which also makes it more clear. Thanks @jasmussen, I simplified the placeholder to just that span tag. 👍 |
Contributor
|
Nice! Ship it. |
Contributor
|
@mkaz Two side effects of this one:
GIF showing the message, and the spinner recurring: This makes the block feel a bit brittle. Can we follow up with a few tweaks?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If no pages exist the Page List block will be empty, making it impossible to select in the rendered view in editor. This PR adds an empty placeholder to show where the block would be and allows for selecting in rendered view.
The Page List block can be empty if a user deletes all pages, or while working on #31471 there may be no children when showing a child list.
How has this been tested?
Screenshots
Types of changes