Pullquote Block: Add font size and line height to the Pullquote block

[danieldudzic]

Description

Add support for font size and line height to the Pullquote Block

With this change, at the moment, the setting targets the font size of the citation, this should probably be changed to target the text.

How has this been tested?

Tested in TT1 Blocks

Screenshots

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @danieldudzic! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[scruffian]

This works as expected, but it does add the controls to the block. I'm not sure what the core team feels about this...

[jasmussen]

This is what I see:

I don't mind that personally, as the controls are added to the inspector. And presumably they would benefit from any typography panel related improvements we make as part of #27331, so no objections here.

Edit: Also: thank you for your first PR to the repository! Woop!

[oandregal]

👋 Code-wise, this is how we add support for style properties automatically, etc. It'd be good from this point of view.

However, when testing this, things don't work as expected. There are a variety of style clashes coming from Gutenberg and the theme. See:

210302-1716-test-pullquote-block-supports.mp4

There's also the question that this block has two text items: the content and the citation, but the block only has a single UI component for font size. It sounds to me that users should be able to tweak these things separately?

(Haven't tested line-height in depth).

[carolinan]

Font size and line height has been added to the block. I believe it was done in #34064.