Skip to content

Support for custom setting of fontSize & padding on a button#26501

Closed
AlexChariyska wants to merge 1 commit into
WordPress:trunkfrom
AlexChariyska:add/support-for-custom-padding-and-font-size-on-button
Closed

Support for custom setting of fontSize & padding on a button#26501
AlexChariyska wants to merge 1 commit into
WordPress:trunkfrom
AlexChariyska:add/support-for-custom-padding-and-font-size-on-button

Conversation

@AlexChariyska

Copy link
Copy Markdown

Description

#20967 Adds a way to control the font size and padding of buttons block
Font size can be one of the defined values in the dropdown or a custom value
Padding is a custom value with shown visualizers when editing it.

How has this been tested?

Manually by adding the button block. Changes should be applied on the block and visualized when saving the post.

Screenshots

Settings Panel:
Screenshot 2020-10-26 at 15 05 14

Custom padding and font-size on a button:
Screenshot 2020-10-26 at 15 03 47
Screenshot 2020-10-27 at 13 50 32
Example on a saved post preview:
Screenshot 2020-10-27 at 14 28 36

Types of changes

New feature (non-breaking change which adds functionality)
Adds control for the button font-size & padding

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@pablinos pablinos mentioned this pull request Nov 20, 2020
6 tasks
Base automatically changed from master to trunk March 1, 2021 15:44
@ramonjd

ramonjd commented Aug 26, 2021

Copy link
Copy Markdown
Member

I think the work on block supports has superseded this one.

The Button block supports padding as of #33859

See also #33447

@ramonjd ramonjd added [Block] Buttons Affects the Buttons Block [Status] Needs More Info Follow-up required in order to be actionable. labels Aug 26, 2021
@skorasaurus

Copy link
Copy Markdown
Member

Thanks for your contributions; since published; padding and font size capabilities have been added to the button block; rendering this PR moot.

@skorasaurus skorasaurus closed this Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Buttons Affects the Buttons Block [Status] Needs More Info Follow-up required in order to be actionable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants