Add anchor support to dynamic blocks#24699
Conversation
Soean
added
[Feature] Blocks
| ...settings.attributes, | ||
| anchor: { | ||
| let anchor = { | ||
| type: 'string', |
There was a problem hiding this comment.
I am not sure why we need this line, this should already be added with PHP.
|
Size Change: +37 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
|
@Soean were you still interested in working on this one? |
talldan
added
the
[Status] Stale
|
@Soean This feature is quite interesting, so if you can, please do it:). I implemented it in my project based on your PR. But I would like to have it in WP core. |
@cr0ybot You can't see it now, but there were about many merge conflicts to resolve and the code was untouched for a long time, so it was impossible to review correctly or merge. Also @Soean hadn't replied in over 1 1/2 years to the message above (#24699 (comment)). The best thing to do would be to make a new pull request with conflicts resolved. One of the problems with leaving a pull request open for a long time is it can also deter other contributors who are sensitive about stepping on someone else's toes, so I decided it's best to clear the decks. Someone had also assigned themselves to #29401, and then not produced any work, so I've also removed that assignee, and hopefully now it's clear that this is a task that's available to pick up. I've also just added the 'Needs Dev' label to make it even clearer. You are right though, I should've left a comment explaining that when I closed it. 👍 |
|
I will create a new pull request to solve this issue. |
|
New WIP PR: #44771 |
5 participants
Description
Add anchor support to dynamic blocks
ToDo