[PCP] Phase 1: wp_function_not_compatible_with_requires_wp#236
Open
faisalahammad wants to merge 1 commit into
Open
[PCP] Phase 1: wp_function_not_compatible_with_requires_wp#236faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
Wrap wp_scripts_get_suffix() in function_exists() guard with 4.9-compatible SCRIPT_DEBUG fallback. CodeRabbit review: add defined() guard for SCRIPT_DEBUG constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
wp_function_not_compatible_with_requires_wp(lines 378, 758, 1030)Changes
wp_scripts_get_suffix()infunction_exists()guard with WP 4.9-compatible fallback usingdefined('SCRIPT_DEBUG') && SCRIPT_DEBUGto default to.minor empty stringfunction_exists()guards — these are PCP false-positives (static analysis flags the call site even with runtime guards)Rule code
wp_function_not_compatible_with_requires_wpVerification
WordPress,PHPCompatibilitystandards shows zero new violationsSCRIPT_DEBUGconstant guard withdefined()checkRequires at least: 4.9— fallback preserves backward compat