Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Fix wp-text directive in SSR #188

Merged
SantosGuillamot merged 3 commits into from
Mar 21, 2023
Merged

Fix wp-text directive in SSR #188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd18064
Use `WP_Directive_Processor` class
SantosGuillamot Mar 21, 2023
ac35c9c
Change bookmarks end in `set_inner_html`
SantosGuillamot Mar 21, 2023
7a9844f
Revert "Change bookmarks end in `set_inner_html`"
SantosGuillamot Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wp-directives.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ function process_directives_in_block( $block_content ) {
'data-wp-text' => 'process_wp_text',
);

$tags = new WP_HTML_Tag_Processor( $block_content );
$tags = new WP_Directive_Processor( $block_content );

@ockham ockham Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this!

(wp-directives.php is the one file that doesn't have unit test coverage, as it's kind of instantiating everything, so it'd be more of a case for integration testing.)

@SantosGuillamot SantosGuillamot Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem at all 🙂 We will need integration testing at some point that should handle this.

$tags = wp_process_directives( $tags, 'data-wp-', $directives );
return $tags->get_updated_html();
}
Expand Down