This repository was archived by the owner on Jul 28, 2023. It is now read-only.
Add wp-text directive#173
Merged
Merged
Conversation
23 tasks
Member
I would not introduce more complexity for which we don't even know what use cases it would cover. |
luisherranz
approved these changes
Mar 9, 2023
Co-authored-by: Luis Herranz <luisherranz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to add the logic for the
wp-textdirective. It doesn't aim to cover the SSR as, if I am not mistaken, that would be handled in this other PR.While implementing it I wondered: Should it be possible to use more than one
wp-textattribute in the same tag? If so, what would it happen? Would they join somehow or they are replaced? I can move this to another discussion if you believe that's more appropriate.