-
Notifications
You must be signed in to change notification settings - Fork 152
Add a core/settings ability #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorgefilipecosta
wants to merge
5
commits into
develop
Choose a base branch
from
add/core-settings-ability
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b3e4f7a
Add a core/settings ability
jorgefilipecosta a431013
Run the core/settings client-side e2e from the editor with an experim…
jorgefilipecosta 7a2f0a0
Rename the core/settings 'slugs' input to 'settings'
jorgefilipecosta 8970d2d
Test that core/settings exposes settings registered by other plugins
jorgefilipecosta 66c05ed
Address review feedback on the core/settings ability
jorgefilipecosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,309 @@ | ||
| <?php | ||
| /** | ||
| * The `core/settings` WordPress Ability. | ||
| * | ||
| * @package WordPress\AI | ||
| * | ||
| * @since x.x.x | ||
| */ | ||
|
|
||
| declare( strict_types=1 ); | ||
|
|
||
| namespace WordPress\AI\Abilities\Settings; | ||
|
|
||
| // Exit if accessed directly. | ||
| defined( 'ABSPATH' ) || exit; | ||
|
|
||
| /** | ||
| * Class - Settings | ||
| * | ||
| * Registers the read-only `core/settings` ability, which returns WordPress settings as a | ||
| * flat map of setting name to value. Only settings flagged with `show_in_abilities` are | ||
| * exposed. It is structured to also back a future write-oriented `core/manage-settings` | ||
| * ability via the shared helpers (get_exposed_settings(), value_schema(), cast_value()). | ||
| * | ||
| * This class is kept almost identical to the WordPress core class `WP_Settings_Abilities` | ||
| * so the two implementations stay in sync. Differences from the core class are marked with | ||
| * `// Plugin:` comments. Additionally, all user-facing strings use the 'ai' text domain. | ||
| * | ||
| * @internal This class should not be used outside the plugin and there is no guarantee of backwards compatibility. | ||
| * | ||
| * @since x.x.x | ||
| */ | ||
| class Settings { | ||
|
|
||
| /** | ||
| * The ability category used for settings abilities. | ||
| * | ||
| * @since x.x.x | ||
| * @var string | ||
| */ | ||
| public const CATEGORY = 'site'; | ||
|
|
||
| /** | ||
| * Settings exposed through the Abilities API, computed once at registration. | ||
| * | ||
| * Plugin: cached so the input/output schema and the executed result derive from the exact | ||
| * same structure, and {@see get_registered_settings()} is only walked once per request. | ||
| * | ||
| * @since x.x.x | ||
| * @var array<string, array{option: string, group: string, default: mixed, schema: array<string, mixed>}>|null | ||
| */ | ||
| private static $exposed_settings = null; | ||
|
|
||
| /** | ||
| * Hooks the ability into the Abilities API. | ||
| * | ||
| * Plugin: this method has no equivalent in the core class. In core, register() is | ||
| * invoked directly from wp_register_core_abilities() (already on the | ||
| * `wp_abilities_api_init` hook). The plugin instead hooks register() slightly later | ||
| * (priority 11) so it can override any core-provided copy. | ||
| * | ||
| * @since x.x.x | ||
| */ | ||
| public static function init(): void { | ||
| add_action( 'wp_abilities_api_init', array( self::class, 'register' ), 11 ); | ||
| } | ||
|
|
||
| /** | ||
| * Registers all settings abilities. | ||
| * | ||
| * Must run on the `wp_abilities_api_init` hook. | ||
| * | ||
| * @since x.x.x | ||
| */ | ||
| public static function register(): void { | ||
| self::register_get_settings(); | ||
|
|
||
| /* | ||
| * A future write-oriented ability can be registered here, reusing the shared | ||
| * helpers below (get_exposed_settings(), value_schema(), cast_value()): | ||
| * | ||
| * self::register_manage_settings(); | ||
| */ | ||
| } | ||
|
|
||
| /** | ||
| * Registers the read-only `core/settings` ability. | ||
| * | ||
| * @since x.x.x | ||
| */ | ||
| public static function register_get_settings(): void { | ||
| // Plugin: unregister any core-provided copy first so the plugin's version wins. | ||
| if ( wp_has_ability( 'core/settings' ) ) { | ||
| wp_unregister_ability( 'core/settings' ); | ||
| } | ||
|
|
||
| // Compute once; execute_get_settings() reuses this exact structure. | ||
| self::$exposed_settings = self::get_exposed_settings(); | ||
|
|
||
| $settings = self::$exposed_settings; | ||
| $field_names = array_keys( $settings ); | ||
| $groups = array(); | ||
| $properties = array(); | ||
| foreach ( $settings as $exposed_name => $setting ) { | ||
| $properties[ $exposed_name ] = $setting['schema']; | ||
| if ( '' === $setting['group'] || in_array( $setting['group'], $groups, true ) ) { | ||
| continue; | ||
| } | ||
| $groups[] = $setting['group']; | ||
| } | ||
|
|
||
| wp_register_ability( | ||
| 'core/settings', | ||
| array( | ||
| 'label' => __( 'Get Settings', 'ai' ), | ||
| 'description' => __( 'Returns WordPress settings as a flat map of setting name to value. By default returns all settings exposed to abilities, or optionally a subset filtered by settings group, by setting name, or both.', 'ai' ), | ||
| 'category' => self::CATEGORY, | ||
| 'input_schema' => self::get_settings_input_schema( $groups, $field_names ), | ||
| 'output_schema' => array( | ||
| 'type' => 'object', | ||
| 'description' => __( 'A map of setting name to its current value.', 'ai' ), | ||
| 'properties' => $properties, | ||
| 'additionalProperties' => false, | ||
| ), | ||
| 'execute_callback' => array( self::class, 'execute_get_settings' ), | ||
| 'permission_callback' => array( self::class, 'has_permission' ), | ||
| 'meta' => array( | ||
| 'annotations' => array( | ||
| 'readonly' => true, | ||
| 'destructive' => false, | ||
| 'idempotent' => true, | ||
| ), | ||
| 'show_in_rest' => true, | ||
| ), | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Executes the `core/settings` ability. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @param mixed $input Optional. The ability input. Default empty array. | ||
| * @return array<string, mixed> Map of exposed setting name to current value. | ||
| */ | ||
| public static function execute_get_settings( $input = array() ): array { | ||
| $input = is_array( $input ) ? $input : array(); | ||
|
|
||
| $settings = self::$exposed_settings ?? self::get_exposed_settings(); | ||
| $group = isset( $input['group'] ) && is_string( $input['group'] ) ? $input['group'] : ''; | ||
| $fields = isset( $input['fields'] ) && is_array( $input['fields'] ) ? $input['fields'] : array(); | ||
|
|
||
| $result = array(); | ||
| foreach ( $settings as $exposed_name => $setting ) { | ||
| if ( '' !== $group && $setting['group'] !== $group ) { | ||
| continue; | ||
| } | ||
| if ( ! empty( $fields ) && ! in_array( $exposed_name, $fields, true ) ) { | ||
| continue; | ||
| } | ||
|
|
||
| $type = isset( $setting['schema']['type'] ) && is_string( $setting['schema']['type'] ) ? $setting['schema']['type'] : 'string'; | ||
| $value = get_option( $setting['option'], $setting['default'] ); | ||
|
|
||
| $result[ $exposed_name ] = self::cast_value( $value, $type ); | ||
| } | ||
|
|
||
| return $result; | ||
| } | ||
|
|
||
| /** | ||
| * Checks whether the current user may use the settings abilities. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @return bool True if the current user can manage options. | ||
| */ | ||
| public static function has_permission(): bool { | ||
| return current_user_can( 'manage_options' ); | ||
| } | ||
|
|
||
| /** | ||
| * Builds the input schema for the get ability: optional filters by group and/or name. | ||
| * | ||
| * Both `group` and `fields` are optional; supplying both narrows the response to their | ||
| * intersection, and supplying neither returns every exposed setting. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @param string[] $groups Available settings groups. | ||
| * @param string[] $field_names Available exposed setting names. | ||
| * @return array<string, mixed> The input JSON Schema. | ||
| */ | ||
| protected static function get_settings_input_schema( array $groups, array $field_names ): array { | ||
| return array( | ||
| 'type' => 'object', | ||
| // Object (not array()) so the serialized schema default is {}, consistent with type:object. | ||
| 'default' => (object) array(), | ||
| 'properties' => array( | ||
| 'group' => array( | ||
| 'type' => 'string', | ||
| 'enum' => $groups, | ||
| 'description' => __( 'Return only settings that belong to this settings group.', 'ai' ), | ||
| ), | ||
| 'fields' => array( | ||
| 'type' => 'array', | ||
| 'items' => array( | ||
| 'type' => 'string', | ||
| 'enum' => $field_names, | ||
| ), | ||
| 'description' => __( 'Return only the settings with these names.', 'ai' ), | ||
| ), | ||
| ), | ||
| 'additionalProperties' => false, | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the settings exposed through the Abilities API. | ||
| * | ||
| * Reads {@see get_registered_settings()} and keeps only settings flagged with a truthy | ||
| * `show_in_abilities` argument. Each entry is keyed by its exposed name and carries the | ||
| * underlying option name, the settings group, the registration default, and a JSON Schema | ||
| * describing the value. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @return array<string, array{option: string, group: string, default: mixed, schema: array<string, mixed>}> Settings keyed by exposed name. | ||
| */ | ||
| protected static function get_exposed_settings(): array { | ||
| $settings = array(); | ||
|
|
||
| foreach ( get_registered_settings() as $option_name => $args ) { | ||
| $show = $args['show_in_abilities'] ?? false; | ||
| if ( empty( $show ) ) { | ||
| continue; | ||
| } | ||
|
|
||
| $option_name = (string) $option_name; | ||
| $exposed_name = is_array( $show ) && isset( $show['name'] ) && is_string( $show['name'] ) && '' !== $show['name'] ? $show['name'] : $option_name; | ||
|
|
||
| $settings[ $exposed_name ] = array( | ||
| 'option' => $option_name, | ||
| 'group' => isset( $args['group'] ) && is_string( $args['group'] ) ? $args['group'] : '', | ||
| 'default' => array_key_exists( 'default', $args ) ? $args['default'] : false, | ||
| 'schema' => self::value_schema( $args, $show ), | ||
| ); | ||
| } | ||
|
|
||
| return $settings; | ||
| } | ||
|
|
||
| /** | ||
| * Builds the JSON Schema describing a single setting's value. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @param array<string, mixed> $args The setting registration arguments. | ||
| * @param bool|array<string, mixed> $show The setting's `show_in_abilities` value. | ||
| * @return array<string, mixed> The value JSON Schema. | ||
| */ | ||
| protected static function value_schema( array $args, $show ): array { | ||
| $schema = array( | ||
| 'type' => isset( $args['type'] ) && is_string( $args['type'] ) ? $args['type'] : 'string', | ||
| ); | ||
| if ( ! empty( $args['label'] ) ) { | ||
| $schema['title'] = $args['label']; | ||
| } | ||
| if ( ! empty( $args['description'] ) ) { | ||
| $schema['description'] = $args['description']; | ||
| } | ||
| if ( is_array( $show ) && isset( $show['schema'] ) && is_array( $show['schema'] ) ) { | ||
| /** @var array<string, mixed> $show_schema */ | ||
| $show_schema = $show['schema']; | ||
| $schema = array_merge( $schema, $show_schema ); | ||
| } | ||
|
|
||
| return $schema; | ||
| } | ||
|
|
||
| /** | ||
| * Casts a stored option value to the type declared in its settings registration. | ||
| * | ||
| * @since x.x.x | ||
| * | ||
| * @param mixed $value The raw option value. | ||
| * @param string $type The registered setting type. | ||
| * @return mixed The value cast to the declared type. | ||
| */ | ||
| protected static function cast_value( $value, string $type ) { | ||
| switch ( $type ) { | ||
| case 'boolean': | ||
| return (bool) $value; | ||
| case 'integer': | ||
| return is_scalar( $value ) ? (int) $value : 0; | ||
| case 'number': | ||
| return is_scalar( $value ) ? (float) $value : 0.0; | ||
| case 'array': | ||
| return is_array( $value ) ? $value : array(); | ||
|
jorgefilipecosta marked this conversation as resolved.
|
||
| case 'object': | ||
| // Cast to object so an empty/non-array value serializes as {} (not []) and | ||
| // satisfies the `object` output schema validated by execute(). | ||
| return (object) ( is_array( $value ) ? $value : array() ); | ||
| default: | ||
| return is_scalar( $value ) ? (string) $value : $value; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.