Mentorship resource images#293
Open
Deejarh wants to merge 2 commits into
Open
Conversation
Deejarh
requested review from
AdniSosa,
IrynaLypnyk,
Madele-theron and
MitaliShah
Deejarh
force-pushed
the
mentorship-resource-images
branch
from
5c783eb to
ad59a2e
Compare
|
dricazenck
reviewed
Jun 30, 2026
| footer: FooterResponse; | ||
| }; | ||
|
|
||
| const resourceImages = [ |
Collaborator
There was a problem hiding this comment.
The images are going to come from the backend, it should not be hardcoded in the frontend, your previous pr was following the correct approach.
Contributor
Author
There was a problem hiding this comment.
Yes I noticed the google drive link still fails to render the image(it's not reliable).
I think loading the image from the frontend is a temporary fix. what do you think @dricazenck ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the mentorship resource page changes from #277, which were reverted in #279 due to broken resource card images, and updates the page to use the backend mentorship resources response shape.
Root Cause
The backend can provide mentorship resource image paths as Google Drive URLs, for example:
https://drive.google.com/uc?id=<file-id>Those URLs are not reliable as direct
<img src="">values. In the browser, Google Drive may redirect through download/auth flows, or return a response that is not a clean image resource. As a result, the resource cards can show broken images even though the URLs may appear to work when opened directly.Fix
/mentee_guideMedia.jpg/mentor_pocketbookMedia.jpg/mentor_guideeMedia.jpgImageobject withpathNote: backend image paths are currently not used for the displayed card artwork because Google Drive image URLs are unreliable for direct rendering in resource cards.
Screenshots
Before
After
Type
Related Issue
Testing
Pull request checklist
Please check if your PR fulfills the following requirements: