Bug/fix mentee reg#724
Merged
Sowmiya07 merged 3 commits intoJul 1, 2026
Merged
Conversation
Sowmiya07
requested review from
Tooonia,
dricazenck,
goelsonali,
lauracabtay,
nora-weisser and
nverbic
nora-weisser
approved these changes
Jun 28, 2026
Contributor
Author
|
Fix: Preserve memberTypes and profileStatus on existing mentee update MenteeService.handleMenteeWithId — capture the existing mentee from findById and merge its memberTypes before calling update. PostgresMenteeRepository.update / create — resolve profileStatus once from the existing record if null in the incoming mentee, reusing the findById result already in scope to avoid redundant DB calls. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Preserve memberTypes and profileStatus on existing mentee update
When a mentee re-registers, the incoming request carries neither memberTypes nor profileStatus, causing a @notempty validation failure and a NullPointerException respectively.
MenteeService.handleMenteeWithId — capture the existing mentee from findById and merge its memberTypes before calling update.
PostgresMenteeRepository.update / create — resolve profileStatus once from the existing record if null in the incoming mentee, reusing the findById result already in scope to avoid redundant DB calls.
Add Endpoint for Cycle Status Update