Desafio 1 - Estruturação do template com HTML5#5
Open
IT-maiara-costa wants to merge 2 commits into
Open
Conversation
happymoon
self-requested a review
December 12, 2018 17:54
happymoon
reviewed
Dec 12, 2018
| <a href="tel:+5521987654321">+55 21 987654-321</a><br/> | ||
| </address> | ||
|
|
||
| <h3>Mídias</h3> |
There was a problem hiding this comment.
aqui vc abriu um título mas não colocou nenhum conteúdo, pretende colocar? Caso não, não precisa do título.
Author
There was a problem hiding this comment.
Irei por os icons depois
happymoon
reviewed
Dec 12, 2018
|
|
||
| </section> | ||
|
|
||
| <br> |
There was a problem hiding this comment.
Avalia se é realmente necessário o uso de <br>, pois se é apenas para dar uma margem entre os elementos, é recomendável fazer isso utilizando CSS no próximo passo e não gerar uma linha extra com um caractere sem função semântica.
happymoon
reviewed
Dec 12, 2018
happymoon
left a comment
happymoon
left a comment
There was a problem hiding this comment.
Em geral está bem limpo e organizado seu código Maiara, meus parabéns :)
Atualizando seu repo com os novos desafios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.