Skip to content

[Mariana Ruddy] Desafio 2#18

Open
marianaruddy wants to merge 49 commits into
WoMakersCode:masterfrom
marianaruddy:desafio2
Open

[Mariana Ruddy] Desafio 2#18
marianaruddy wants to merge 49 commits into
WoMakersCode:masterfrom
marianaruddy:desafio2

Conversation

@marianaruddy

Copy link
Copy Markdown

estou meio confusa com o git entao acabei criando outro pr para o desafio 2, acho que consertei ja todos os comentarios feitos no pr do desafio 1

@LorTrindade @glaucia86

pull request do desafio 1:https://github.com/WoMakersCode/front-end-study-group-rj/pull/15

@marianaruddy marianaruddy changed the title Desafio 2 [Mariana Ruddy] Desafio 2 Jan 3, 2019
@glaucia86

Copy link
Copy Markdown

LGTM 👍
Aprovando o teu PR.
Falta agora só a análise e aprovação da @LorTrindade

@glaucia86 glaucia86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread meudesafio/page.html Outdated
<div class="transition"></div>
<section class="welcome-wrapper">
<div class="carousel">
<div class="carousel-welcome">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marianaruddy para a sua duvida do background da imagem.
o background dela já é uma imagem, então uma maneira de mudar sua cor seria criando outra div em cima dela
e mudando sua transparencia .

Exemplo

`.carousel-welcom {
background: url(../images/Slider.png) repeat-x 0% center;
}

.containerEmcimaDeCarousel{
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
background: #fb1655;
opacity: 0.85;
}`

Comment thread meudesafio/page.html Outdated
/></a>
<nav class="menu-itens">
<a class="menu-item" href=""><span>Home</span></a>
<a class="menu-item" href=""><span>Serviços</span></a>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

você pode fazer seu portfolio navegar entre seções e deixa-lo mais interativo mudando seu href para o id da sua seção exemplo :

href="#servicos"

Comment thread meudesafio/page.html Outdated
>In aliquet vitae dui vitae efficitur. Donec non convallis enim.
</span>
</div>
<div class="service">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o href="#servicos" seta para o id servicos, então sua div ficaria assim :

<div class="service" id ="servicos">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants