Skip to content

Desafio-1#13

Open
lcazev wants to merge 1 commit into
WoMakersCode:masterfrom
lcazev:master
Open

Desafio-1#13
lcazev wants to merge 1 commit into
WoMakersCode:masterfrom
lcazev:master

Conversation

@lcazev

@lcazev lcazev commented Dec 19, 2018

Copy link
Copy Markdown

No description provided.

@lcazev

lcazev commented Dec 19, 2018

Copy link
Copy Markdown
Author

@tarcilas

@lcazev lcazev closed this Dec 19, 2018
@lcazev lcazev reopened this Dec 19, 2018

@tarcilas tarcilas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns, continue assim!

Comment thread index.html
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href=""><script src=""></script>
<title>Womakerscode</title>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coloca o favicon (icon.ico)

Comment thread index.html

<body>
<img src="images/logo.png" alt="Logo Womakers Code" width="100px">
<ul>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isso é um menu, não apenas uma lista, então sua tag nav com links para as respectivas seções do site.

https://www.w3schools.com/tags/tag_nav.asp

Comment thread index.html
<li>Contato</li>
</ul>

<div class="welcome">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

É mais semântico usar a tag section para demarcar as seções

https://www.w3schools.com/tags/tag_section.asp

Suggested change
<div class="welcome">
<section id="home" class="welcome">

Comment thread index.html
<div class="welcome">
<h1>Bem vind@</h1>
<h2>Curabitur Iaculis</h2>
<h5>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras consequat ultricies facilisis. Quisque varius tortor eget lacus tincidunt cursus. </h5>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

É uma boa prática respeitar a hierarquia dos Headings h1, h2, h3..., não usar só por causa do tamanho da fonte, pois isso depois será mudado na aplicação de estilos

Comment thread index.html


</div>
<div class="quem-eu">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seria legal já customizar os textos, foto, contatos e redes sociais com suas informações, afinal esse será seu portfólio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants