QoL patch: auto-refresh after adding new game(s)#256
Open
FaceCrap wants to merge 2 commits into
Open
Conversation
Works when adding a new game via extension and from search result popup after typing in input box at bottom
Owner
|
not opposed to this, but i see 1 potential issue. if adding multiple games, and refreshing one takes long enough, the next one will be added while still refreshing the previous one, and it just wont be refreshed, leading to inconsistent results with some refreshed and some not |
Added a separate list to hold the new games Instead of calling `utils.start_refresh_task` changed the call to `await api.refresh(*games, full=True, notifs=False)` since we do not want to reset the background timers for an actual refresh. Checked if the length of the list is greater than zero before calling the refresh so as not to do a full refresh on the full list if length IS zero. Changed the popup text to use the now known names.
Contributor
Author
Also added as description for the commit |
FaceCrap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple one-line addition.
Works when adding a new game via extension and from search result popup after typing in input box at bottom