Modular refactor: split kraken.sh into lib/ with shellcheck-clean modules#1
Merged
Conversation
The v1.0.0 history is preserved by the existing tag on the remote. This merge brings the two histories together so the refactor can land on main via a standard PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kraken.shintolib/helpers andlib/modules/tentacles (entry point now ~130 lines)set -efrom the interactive menu (a single non-zero exit code from any wrapped tool was tearing down the loop)ensure_command/ensure_repo/prompt_value/prompt_yesnohelpers - new tools integrate in ~5 lineslog_step/log_info/log_warn/log_error/log_successteeor filesKRAKEN_*What is new
.github/workflows/ci.yml: shellcheck (warning) +bash -non all*.sh+ smoke test verifying 24 exposed functions.github/ISSUE_TEMPLATE/: bug report and module request templates (YAML).github/PULL_REQUEST_TEMPLATE.mdCONTRIBUTING.md,CODE_OF_CONDUCT.md,SECURITY.mddocs/ARCHITECTURE.md: boot sequence, module contract, color model, session layoutdocs/ADDING_A_MODULE.md: step-by-step recipe with Don't / Do tableLICENSE(MIT),.gitignore,.editorconfigProject layout
Test plan
bash -npasses on all 11*.shfiles./kraken.sh --helpand./kraken.sh --versionworkNotes
This branch rebuilds the repository from a clean
git init. The pre-refactor history is merged in via the finalMerge unrelated pre-refactor historycommit, so the v1.0.0 history remains reachable frommainafter this PR lands.