Hardening v1.2: input validation, menu registry, portability#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening and refactor pass. Ten focused commits, each verified with
bash -nand the CI smoke check (source chain + expected functions).Security / correctness
lib/core.sh(fys_is_port,fys_is_port_spec,fys_is_ipv4,fys_is_hostname,fys_is_host,fys_is_cidr,fys_is_host_or_cidr) plus aprompt_validwrapper that re-prompts on bad input. Every module now validates targets, ports, CIDR ranges and domains instead of passing raw/empty values to tools.mapfile/|&are used throughout.ludeeus/action-shellcheckpinned to2.0.0instead ofmaster.Architecture
FEEDYOURSPIDER_TOOLS): the menu renderer and the dispatcher both derive from one list, removing the previous dual source of truth.run_custom_argshelper: deduplicates the repeated per-module custom-args branches.UX
NO_COLORenvironment variable honored.Docs / housekeeping
CONTRIBUTING.md,CODE_OF_CONDUCT.md,SECURITY.mdmoved into.github/to keep the repo root clean (GitHub still auto-detects them); cross-links fixed.docs/CHANGELOG.md; version bumped 1.1.0 -> 1.2.0.Test
bash -non every*.sh.🤖 Generated with Claude Code