fix: wrap widget library in DetailDrawerProvider#115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-existing bug shipped in v1.0.0 (introduced by e31586b on June 29, before the release hardening): the detail drawer commit added useDetailDrawer to 8 dashboard widgets, but /dashboard/widgets renders those widgets as previews outside DetailDrawerProvider, so the page crashes with 'useDetailDrawer must be used within DetailDrawerProvider'. Nothing covered that page: unit tests do not render pages and the smoke test stopped at dashboard/alerts.
Fix: wrap the widget library page in DetailDrawerProvider (self-contained, mounts the drawer portal itself), so previews render and are even clickable like on the real dashboard.
Smoke test hardened to catch this class of bug: a pageerror collector fails the run on any uncaught client error on visited pages, and the spec now visits /dashboard/widgets and asserts real content (Widget Library heading, Alert Severity widget). Verified RED with the bug, GREEN with the fix.