Conversation
eliminated redundant oauth-related variables from the .env file and removed obsolete test assertions for unused database tables. these changes streamline the configuration and improve test clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
ClientRegistration생성이 실패하지 않도록 stub 값을 제공127.0.0.1:65535로 고정해 테스트 중 실제 GitHub OAuth 서버 호출이 발생하지 않도록 구성OAuth2SecuritySupportConfig로 분리해SecurityConfig가 명시적으로 가져오도록 변경OAuth2ClientAutoConfiguration도 함께 제외하도록 정리구성 흐름
flowchart LR subgraph CI["CI / 기본 테스트"] A["application-sso.yaml<br/>stub client + fake provider endpoint"] --> B["Spring OAuth2 ClientRegistration"] B --> C["SecurityConfig<br/>oauth2Login filter chain"] C --> D["실제 GitHub 호출 없음<br/>endpoint 접근 시에만 fake 주소 사용"] end subgraph Runtime["실제 SSO 실행"] E["env override<br/>client id / secret / provider uri"] --> B F["GitHub / Google SSO"] --> C C --> G["OAuth2LoginSuccessHandler"] G --> H["대시보드 인증 토큰 발급<br/>현재는 mock token"] end subgraph Test["장기 테스트 전략"] I["MVC slice<br/>security 제외"] --> J["OAuth2ClientAutoConfiguration 제외"] K["SSO 통합 테스트"] --> L["Fake OAuth server<br/>authorize / token / userinfo stubbing"] L --> C end검증
./gradlew staticCheck unitTest supportTest apiE2eTest