Replace NFD Dependency With DialogModule#2761
Conversation
|
Originally ImHex used this same library but it was very unpopular. Another imgui based app (shadered) uses that same file dialog and I noticed in 2023 that the author looked into using it in ImHex. this is what he said when I asked about about it. 
If you join us in discord, you will be able to read more comments about it and about the one used to replace it which you say has problems but have never noticed any. |
|
Hey! Latest commit properly sets the parent window on the file dialogs. I hope this solves some of the issues. About the rest of the PR, having to pull in the entirety of SDL is pretty much a show stopper for me. I've been thinking about replacing GLFW with SDL3 eventually but that will require a ton of work elsewhere. I'd rather not have both in at the same time |
Update CMakeLists.txt
Update file_provider.cpp
Update fs.cpp
Update fs.cpp
3 participants
Problem description
File dialogs, (as provided with the NFD dep), do not support a file filter dropdown box on macOS. This fixes that, by replacing the NFD dependency with
libdlgmod. More details here: https://github.com/samuelvenable/libdlgmodImplementation description
I replaced the NFD dependency with my own file dialogs which are improved ones compared to NFD. They also match the current desktop environment: Qt on KDE, GTK on non-KDE, WinAPI on Windows, and AppKit on macOS.
Screenshots