cleanup-and-update-readme#12
Conversation
Shreyas281299
commented
May 17, 2024
Shreyas281299
commented
- Cleanup and updated readme.
| 2. Get access token for users registered with Webex Calling. If you don't have an account request for a sandbox - https://developer.webex.com/docs/developer-sandbox-guide | ||
| 3. In "js/app.js", put the access tokens (line 126, 128) | ||
| 4. Run `yarn start` | ||
| 5. Navigate to [http://127.0.0.1:9000](http://127.0.0.1:9000) |
There was a problem hiding this comment.
you need to specify here that mytrips.html is one page and other one is agent.html
| @@ -1,81 +0,0 @@ | |||
| CISCO SAMPLE CODE LICENSE | |||
There was a problem hiding this comment.
We should find what the template's license is and add it instead, I believe.
There was a problem hiding this comment.
@adamweeks - Looking to know your thoughts on this one
There was a problem hiding this comment.
@mkesavan13 I believe @ashjorda has updated this repo with the correct license file needed.
There was a problem hiding this comment.
@Shreyas281299 - In which case, we shouldn't remove this file. Please add it back
There was a problem hiding this comment.
@ashjorda has already removed this duplicate lisence.md.
mkesavan13
left a comment
mkesavan13
left a comment
There was a problem hiding this comment.
Just one comment. We can discuss that with Adam Weeks if required
| callerNumber.innerText = CallerIdEmitter.callerId.num; | ||
| }); | ||
|
|
||
| incomingCall.on("remote_media", (track) => { |
There was a problem hiding this comment.
We also should add an event listener for hold success, hold error, resume success and resume failure for both the call objects in this file.
4 participants
