to main#861
Merged
Merged
Conversation
Templates are now keyed by (type, stage) instead of type alone: - template schema gains `stage` (cold|returning, default cold); the old `type`-unique constraint becomes a (type, stage) compound unique index; template dedup + list filter are stage-aware. - venue gains `relationshipStage` (explicit override, unset = auto) and `templateOverride` (force a template type for special cases). - send selection: type = templateType > venue.templateOverride > venueType; stage = explicit relationshipStage, else auto-derived (booked or prior replied/booked outreach => returning, else cold); findTemplate falls back returning->cold so sends never break before a returning variant is authored, and matches legacy stage-less templates. v2.0.34, 308 tests green. NOTE: after deploy, set stage='cold' on the 3 existing prod templates (so dedup matches them); sends already work via the cold fallback. Venue-editor controls for the two new fields are a small JaMmusic follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
.jscpd.json (TS/JS, 5% threshold, csv/tests/build ignored) + npm run jscpd, chained into npm test so CI enforces it (currently 4.57% lines). No version bump — same PR (#860), one semver bump per PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reproduced the intermittent 'should update one book' 401: integration
specs share one Mongo test DB and three (book-router/gig-router/facebook)
call userModel.deleteMany({}). Files overlapped enough that one file's
user-wipe ran during another's in-flight auth -> users table momentarily
empty -> findUserById null -> 401 (caught GET /user + PUT /book/one both
401-ing at once). fileParallelism:false serializes files so no cleanup
wipes another file's auth user mid-request. Verified: 8/8 full-suite runs
green (was ~1-in-4 flaky). No version bump — same PR (#860).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
feat(outreach): pick the email template by venueType + relationship stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.