fix: support iOS inline hero video playback#395
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Hero Video section to better support iOS inline playback by ensuring the underlying <video> element is configured with the attributes required for muted inline autoplay on Mobile Safari/Chrome.
Changes:
- Mutates the rendered
<video>element to enforcemuted/defaultMuted,playsinline/webkit-playsinline, and conditionallyautoplay/loop. - Passes
autoPlayandplaysInlineprops to theReactPlayerinstance alongside existingplaying/muted/loopbehavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hta218
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoPlayandplaysInlineattributes to the Hero Video ReactPlayer instance.muted,defaultMuted,playsinline,webkit-playsinline,autoplay, andloopattributes when applicable.Test Plan
npm run typechecknpx biome check app/sections/hero-video/index.tsxnpm run buildNote:
npm run biomestill fails on existing unrelated issues inapp/components/root/consent-banner.tsx,app/components/cart/cart-summary.tsx,app/sections/blog-post.tsx, andapp/utils/checkout-attribution.ts; the changed Hero Video file passes targeted Biome check.