After 24h fasting add small 'days + hours' underneath timer#59
Conversation
|
Next request is adding similar info to the other timers: Fat Burn, Ketosis, Autophagy. |
Not sure what you mean by this. Could you please post this in the Issues area with a bit more info, as this is mainly for discussing the code changes specific to the PR. |
Sorry, I mean similar days/hours/minutes timers for the "Fat Burn", "Ketosis", and "Autophagy" timers. |
|
I think this static code tool is a bit too aggressive... but okay. I'll provide a few more fixes. |
|
Ok Static Code tool seems happy. I would prefer to have this merged over #58 Can we get this done? These have been dangling for like 2 months just based on simple indentation fixes etc. |
|
Wouldn't it make sense to take advantage of the touch event on the hh:mm:ss display - which currently does nothing - and use it to toggle the view between hours vs days? The small text alternative label below would still be useful in this case as it can be used to show the alternative view (hours vs days). E.g. the original screenshot would be the initial state, and tapping the view would swap between the two: 57:00:592 days, 9 hours after tapping: 2 days, 9 hours57:00:59 Wdyt? |
|
I need to check how this looks on a wide variety of screen sizes, you wouldn't believe the problems I've had with the fasting screen on very tiny or very large screens. But I'll get to it this week and hopefully get this merged! |
I would and do believe 😅; layouts can be really tricky to render properly in all viewports; been through it; maybe autosizing can help? e.g. app:autoSizeTextType="uniform"
app:autoSizeMinTextSize="12sp"
app:autoSizeMaxTextSize="100sp"
app:autoSizeStepGranularity="2spor programmatically textView.setAutoSizeTextTypeWithDefaults(TextView.AUTO_SIZE_TEXT_TYPE_UNIFORM)
// with custom bounds
textView.setAutoSizeTextTypeUniformWithConfiguration(
12, 100, 2, TypedValue.COMPLEX_UNIT_SP
)This works similar to used something similar in a project, not perfect and sometimes causes unexpected results but maybe can work if properly configured? |
Adds a small indication of how many days + hours you have been fasting after 24h.