chore: ignore RUSTSEC-2026-0173 (unmaintained proc-macro-error2)#300
Merged
Conversation
proc-macro-error2 enters the graph only as a phantom transitive dep behind jiff's optional, disabled defmt feature: gix -> gix-date -> jiff -> defmt (optional, off) -> defmt-macros -> proc-macro-error2. It is never compiled into the binary, and the latest jiff/defmt-macros still pull it in, so it cannot be removed by upgrading. Suppress the cargo-audit warning via .cargo/audit.toml until upstream defmt-macros migrates off proc-macro-error2. Assisted-by: Claude (Anthropic) Signed-off-by: hydai <z54981220@gmail.com>
Contributor
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 352c2202fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dm4
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the RUSTSEC-2026-0173 advisory reported in #299 by ignoring it in the
cargo-audit configuration.
proc-macro-error2is flagged as unmaintained — an informational advisory,not a security vulnerability (
cargo auditreportsvulnerabilities.count = 0;it only appears under
warnings.unmaintained). It is never compiled into thebinary: it enters only as a phantom transitive dependency behind
jiff'soptional, disabled
defmtfeature:cargo tree -e normal -i proc-macro-error2(including--target all) printsnothing, confirming it is absent from the actual build graph. The latest
jiff(0.2.29) and
defmt-macros(1.1.0) still reference it, so it cannot be removedby upgrading, nor can the suggested alternatives (manyhow /
proc-macro2-diagnostics) be adopted from our side — that is upstream's call.
Change
Add
.cargo/audit.tomlwithignore = ["RUSTSEC-2026-0173"].Verified locally with cargo-audit 0.22.1: after this change
cargo auditnolonger emits the warning (its
warningsset becomes empty), so the scheduledrustsec/audit-checkjob will stop re-filing this issue. The ignore entry isdocumented inline and should be dropped once upstream
defmt-macrosmigratesoff
proc-macro-error2.Closes #299
This contribution was developed with assistance from Claude (Anthropic).