Skip to content

remove default value for inputs.arch - breaks auto-detection - #29

Open
fclante wants to merge 1 commit into
Warchant:masterfrom
fclante:fix-default-arg-evaluation
Open

remove default value for inputs.arch - breaks auto-detection#29
fclante wants to merge 1 commit into
Warchant:masterfrom
fclante:fix-default-arg-evaluation

Conversation

@fclante

@fclante fclante commented Jul 6, 2026

Copy link
Copy Markdown

remove default value for inputs.arch because it breaks the auto-detection fallback to getArch()

Before:

If no input value for arch is is supplied it auto-fallback to 'x64' which shunts getArch() method entirely.

   const arch = core.getInput('arch', { required: false }) || getArch();

After:

If no value is supplied for arch it falls back to getArch()

const getArch = () => {
  switch(process.arch) {
    case 'x64':
      return 'x64'
    case 'arm64':
      return 'aarch64'
    default:
      throw new Error(`Unsupported architecture: ${process.arch}`);
  }
}

@fclante

fclante commented Jul 24, 2026

Copy link
Copy Markdown
Author

@Warchant Hi - Did you have a chance to look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant