realign with api changes#1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR realigns the TypeScript SDK and accompanying examples/tests/docs with updated API behavior, adding bidirectional Solana ↔ Base swap support (including EVM-source swaps returning an ordered transaction array) and updating the swap fee endpoint to return a structured fee breakdown.
Changes:
- Update SDK types to support EVM transaction arrays for Base → Solana swaps and add helper functions to differentiate response shapes.
- Replace the old flat
SwapFeeResponsewith aSwapFeeBreakdownshape (keepingSwapFeeResponseas a deprecated alias) and update tests/e2e to match. - Update CLI, package metadata, and READMEs to document/install/support bidirectional swap flows.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdk/tests/client.test.ts | Extends tests to cover fee breakdown and Base → Solana execute responses + helper checks |
| packages/sdk/src/types.ts | Introduces SwapFeeBreakdown, EvmTransaction, optional execute response fields, and helper functions |
| packages/sdk/src/index.ts | Re-exports new types and helper functions |
| packages/sdk/src/client.ts | Updates getSwapFee() return type and executeSwap documentation for bidirectional behavior |
| packages/sdk/package.json | Updates package description and adds publishConfig |
| packages/sdk/README.md | Updates SDK docs and examples for bidirectional swaps and new response shapes |
| examples/node-cli/src/commands/swap.ts | Adds handling for EVM transaction arrays (Base → Solana) and nullable gas reimbursement |
| examples/node-cli/e2e/sdk-integration.ts | Updates fee breakdown typing assertions |
| examples/node-cli/e2e/api-direct.ts | Updates fee breakdown assertions for direct API calls |
| README.md | Updates top-level docs for bidirectional swaps and revised fee/gas messaging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base support