Skip to content

Normalize syncrule class names to Python style in from_document #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevevanhooser merged 1 commit into from
Mar 17, 2026
Merged

Normalize syncrule class names to Python style in from_document #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ndi/time/syncrule_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,12 @@ def from_document(cls, session: Any, doc: ndi_document) -> ndi_time_syncrule:
Returns:
ndi_time_syncrule instance of the appropriate subclass
"""
# Get class name from document
# Get class name from document and normalize to Python-style
from ..util.classname import ndi_python_classname

props = doc.document_properties
class_name = props.get("syncrule", {}).get("ndi_syncrule_class", "ndi_time_syncrule")
class_name_raw = props.get("syncrule", {}).get("ndi_syncrule_class", "ndi_time_syncrule")
class_name = ndi_python_classname(class_name_raw)
parameters = props.get("syncrule", {}).get("parameters", {})
identifier = props.get("base", {}).get("id")

Expand Down
Loading