Add MATLAB-Python bridge contracts for ndi.daq namespace#25
Merged
Conversation
Create ndi_matlab_python_bridge.yaml contracts for: - ndi/daq/ (DAQSystemString, DAQReader, MFDAQReader, DAQSystem, DAQSystemMFDAQ) - ndi/daq/reader/ (SpikeInterfaceReader) - ndi/daq/reader/mfdaq/ (IntanReader, BlackrockReader, CEDSpike2Reader, SpikeGadgetsReader) - ndi/daq/metadatareader/ (MetadataReader, NewStimStimsReader, NielsenLabStimsReader) Remove unused typing imports (Dict, List, Optional, Tuple, Union) from metadatareader/__init__.py — the code already uses modern syntax. https://claude.ai/code/session_01N4hGaSLpdwZyNUFYHccwq9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive MATLAB-Python bridge contracts for the
ndi.daqnamespace and its submodules. These YAML-based contracts define the interface specifications, type mappings, and semantic parity requirements between MATLAB and Python implementations.Key Changes
Main bridge contract (
src/ndi/daq/ndi_matlab_python_bridge.yaml): Defines the primary contract for thendi.daqnamespace including:standardize_channel_type,standardize_channel_types)ChannelType,ChannelInfo)DAQSystemString,DAQReader(base),MFDAQReader, andDAQSystemReader submodule contract (
src/ndi/daq/reader/ndi_matlab_python_bridge.yaml): Specifies contracts for:SpikeInterfaceReaderclass (Python-specific adapter)MFDAQ reader contract (
src/ndi/daq/reader/mfdaq/ndi_matlab_python_bridge.yaml): Defines format-specific readers:IntanReaderfor Intan RHD/RHS filesBlackrockReaderfor Blackrock NSx/NEV filesCEDSpike2Readerfor CED Spike2 SMR/SMRX filesSpikeInterfaceReaderfor actual data accessMetadata reader contract (
src/ndi/daq/metadatareader/ndi_matlab_python_bridge.yaml): Specifies:MetadataReaderclass for TSV-based metadataNewStimStimsReaderfor NewStim stimulus metadataNielsenLabStimsReaderfor Nielsen Lab stimulus metadataMinor import cleanup in
src/ndi/daq/metadatareader/__init__.py: Simplified type imports to useAnyinstead of specific type hints.Notable Implementation Details
https://claude.ai/code/session_01N4hGaSLpdwZyNUFYHccwq9