-
Notifications
You must be signed in to change notification settings - Fork 6
docs: add base deployment #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,31 @@ | ||
| {"L2WCT":{"address":"0xeF4461891DfB3AC8572cCf7C794664A8DD927945","admin":"0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4","implementation":"0x4D1070C6e37de5870e11b99e2A006739e77ec5cb"},"chainId":8453} | ||
| { | ||
| "L2WCT": { | ||
| "address": "0xeF4461891DfB3AC8572cCf7C794664A8DD927945", | ||
| "admin": "0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4", | ||
| "implementation": "0x4D1070C6e37de5870e11b99e2A006739e77ec5cb", | ||
| "proxy": { | ||
| "implementation": "0x1b9FC26A506B8CC98F65dE60f337c43f97BB2d40", | ||
| "admin": "0x3eD030AAF23b5C52c224Cb72100C22f581D10Df4", | ||
| "type": "transparent" | ||
| } | ||
| }, | ||
| "chainId": 8453, | ||
| "NttManager": { | ||
| "name": "NTT Manager", | ||
| "address": "0x164Be303480f542336bE0bBe0432A13b85e6FD1b", | ||
| "proxy": { | ||
| "implementation": "0xaf6775d329b6fb20cB6DF29ffE9E21FfbD34A7FD", | ||
| "owner": "0x398A2749487B2a91f2f543C01F7afD19AEE4b6b0", | ||
| "type": "uups" | ||
| } | ||
| }, | ||
| "NttTransceiver": { | ||
| "name": "NTT Transceiver", | ||
| "address": "0x3cB1d3A449a868dd8BF8F8928408836543Fe2A68", | ||
| "proxy": { | ||
| "implementation": "0x6eeF2f780493b6F53795FE7C963E2c1aA09B8B16", | ||
| "owner": "0x398A2749487B2a91f2f543C01F7afD19AEE4b6b0", | ||
| "type": "uups" | ||
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import fs from "fs"; | ||
| import { createPublicClient, http, getAddress, isAddress } from "viem"; | ||
| import { mainnet, optimism } from "viem/chains"; | ||
| import { mainnet, optimism, base } from "viem/chains"; | ||
|
|
||
| interface DeploymentEntry { | ||
| name: string; | ||
|
|
@@ -38,6 +38,12 @@ const CHAINS: ChainConfig[] = [ | |
| client: createPublicClient({ chain: optimism, transport: http() }), | ||
| deploymentFile: "evm/deployments/10.json", | ||
| }, | ||
| { | ||
| id: 8453, | ||
| name: "Base", | ||
| client: createPublicClient({ chain: base, transport: http() }), | ||
| deploymentFile: "evm/deployments/8453.json", | ||
| }, | ||
|
Comment on lines
+41
to
+46
|
||
| ]; | ||
|
|
||
| // Contract display names (consistent with generate-deployment-docs.ts) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L2WCT lists two different implementation addresses (top-level implementation 0x4D1070... vs proxy.implementation 0x1b9FC2...) which creates an inconsistent source of truth and can cause tooling to read an outdated or incorrect implementation. Align to a single implementation reference (update the correct one, then remove the redundant field) or ensure both match if both are required for backward compatibility.