Skip to content

Fix cnn and add SatCLIP#107

Merged
vdplasthijs merged 7 commits into
developfrom
feature/fix_cnn
May 21, 2026
Merged

Fix cnn and add SatCLIP#107
vdplasthijs merged 7 commits into
developfrom
feature/fix_cnn

Conversation

@gabrieletijunaityte

@gabrieletijunaityte gabrieletijunaityte commented May 20, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is on top of #106

  • Adds SatCLIP coordinate encoder.
  • Fixes CNN:
    • Trainable layers are appropriately passed on in the setup() method. (Issue CNN trainable layers #64)
    • Moves out model freezing from CNN encoder to the BaseModel.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?

@gabrieletijunaityte gabrieletijunaityte changed the title Feature/fix cnn Fix cnn and add SatCLIP May 20, 2026
@gabrieletijunaityte gabrieletijunaityte mentioned this pull request May 20, 2026
4 tasks
@vdplasthijs

Copy link
Copy Markdown
Collaborator

Let's merge #106 first (before I review/merge), then update the branch of this PR, so the file changes don't duplicate what is in #106.

@vdplasthijs vdplasthijs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I think the use of freezing_strategy in config files (and elsewhere?) needs to be removed, and was just wondering where freezing happens now? Thanks!!

Comment thread src/models/components/geo_encoders/cnn_encoder.py
Comment thread src/models/components/geo_encoders/cnn_encoder.py
Comment thread src/models/components/geo_encoders/cnn_encoder.py
@vdplasthijs vdplasthijs merged commit f98b1fe into develop May 21, 2026
4 checks passed
@vdplasthijs vdplasthijs mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants