fix invert y option not affecting mouse camera#31
Open
EgeDogukan wants to merge 1 commit into
Open
Conversation
apply the saved invert_y setting to mouse pitch input, matching the existing controller right-stick behavior. also fix a copy-paste typo where the x sensitivity was rescaled using the y base constant (no behavior change; both constants are equal). fixes WCGH#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2
the invert y toggle only affected the controller right stick, mouse camera pitch ignored it. this applies the same inversion to the mouse-look path in player_movement_controller.gd, mirroring the existing right-stick branch. the movement controller is shared, so this covers dmu, fru, and dsr alike. live toggle updates already work through on_variable_saved, so no extra wiring was needed.
also fixes a small copy-paste typo in on_variable_saved where the x sensitivity was rescaled with the y base constant (no behavior change, both constants are equal).
tested in the fru sim (godot 4.7, macos): mouse pitch inverts with the toggle on and reverts with it off, including when toggled mid-run. the controller stick path is unchanged (no gamepad on hand to re-test).