Skip to content

WIP create favorites page#71

Open
RomainChamb wants to merge 19 commits into
developfrom
feature/favoris
Open

WIP create favorites page#71
RomainChamb wants to merge 19 commits into
developfrom
feature/favoris

Conversation

@RomainChamb

Copy link
Copy Markdown

No description provided.

@RomainChamb RomainChamb removed the WIP label Nov 23, 2019
@RomainChamb RomainChamb changed the title WIP:create favorites-page create favorites page Nov 23, 2019
@alexbonhomme alexbonhomme changed the title create favorites page WIP create favorites page Dec 8, 2019
@alexbonhomme

Copy link
Copy Markdown
Collaborator

Hi! Thanks for the contrib. I fixed some issues, but it's globally ok !

One feature is missing. A click on a favorite should :

  • set the favorite as active station in the store
  • close the modal
  • center the map on the selected station

As we can't use Output from the modal to trigger action on the map, I think we need to refactor the home.ts to subscribe to the SET_ACTIVE action in order to center the map.

We could discuss implementation details here (or on slack), or in a meeting in a coffee :)

@RomainChamb

RomainChamb commented Dec 14, 2019

Copy link
Copy Markdown
Author

Hi,
Thanks for your feedback. My mistake, I completely forgot this behaviour.

Totally OK to discuss it with a cup of coffee :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants