Make the C++ interface easier to use - #185
Draft
VivekPanyam wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a more convenient way to index into tensors from the C++ API.
Previously, a user would have to explicitly compute an offset based on the strides of a tensor and their desired index (or use an external library).
They would also have to use different methods for string tensors and numeric tensors (e.g.
get_string/set_stringfor dealing with string tensors).This PR provides an
atmethod that lets users pass in an index and get an element. It also provides anaccessormethod that can be used when accessing several elements. These work for both string and numeric tensors.Note: this is a breaking change for the following reasons:
get_stringandset_stringin the C++ API are now private methodscarton_tensor_get_string,carton_tensor_set_string, andcarton_tensor_set_string_with_strlenfrom the C API now expect theirindexargument to take strides into account. This shouldn't have a practical impact as all our current ways of creating string tensors and exposing them via the C API create tensors with standard strides.