destroy app_ instance on guiDestroy#78
Merged
Merged
Conversation
Tested with Reaper on linux, guiDestroy is invoked when closing the UI, or the parent window the plugin is displayed in. This generates a x11 bad window error: X11 Error: 3 To resolve, reset the unique_ptr app_ by assigning nullptr to it. clap/gui.h states that all resources associated with the gui should be freed.
mtytel
reviewed
Feb 3, 2026
|
|
||
| app_->close(); | ||
|
|
||
| #if __linux__ |
Member
There was a problem hiding this comment.
A little cleaner to just leave off the #if
Doesn't hurt to have on other systems.
Contributor
Author
There was a problem hiding this comment.
Haven't tested on other systems but agreed.
assign nullptr to app on all platforms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with Reaper on linux, guiDestroy is invoked when closing the UI, or the parent window the plugin is displayed in. This generates a x11 bad window error: X11 Error: 3
To resolve, reset the unique_ptr app_ by assigning nullptr to it. clap/gui.h states that all resources associated with the gui should be freed.