feat: handles manual transaction approval#12
Open
andrew-virtuals wants to merge 4 commits into
Open
Conversation
Zuhwa
approved these changes
May 13, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 559f5a9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
High Risk
High risk because it changes authentication signing from message-signing to EIP-712 typed data and modifies the Privy/Alchemy transaction submission path to support manual approval and new user-operation signing, impacting wallet security and transaction execution flow.
Overview
Switches agent/provider authentication from
signMessageto EIP-712 typed-data signatures via newcore/agentAuth.tsand updates all auth clients/context to sendissuedAt+ typed data instead of a raw message.Adds a manual approval gate (
core/approvalGate.ts) and a new SSEwalletstream alongside chat;SseTransport.connect()andAcpAgent.start()now accept configurableSupportedStreams(defaulting to chat+wallet) and the wallet stream resolves pending approvals.Updates
PrivyAlchemyEvmProviderAdapterto detect server-sideAPPROVAL_REQUIREDresponses, wait for approval events before continuing, and changes call submission to a prepare/sign-user-operation/send-prepared flow using a configuredALCHEMY_SIGNING_CONTRACT.Reviewed by Cursor Bugbot for commit 1ec514b. Bugbot is set up for automated code reviews on this repo. Configure here.