Conversation
Implements get_classes() on the dragon and rizin disassembler backends, exposing vtable addresses, virtual method slots, base class chains, and multiple/virtual inheritance flags via structural Itanium ABI parsing. Adds C++ test binaries (no-inheritance, 3-level chain, diamond) and a full test suite covering all three scenarios on both backends. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Extract shared itanium_name() decoder into binocular/rtti_util.py, removing duplicated implementations in dragon.py and binja.py - Refactor rizin.py get_classes() nested functions into private _rz_* methods for readability and testability - Add symbol-size-based slot cap in Ghidra and Binja vtable readers to prevent over-reading into the VTT in multiple-inheritance layouts - Fix VMI flags bound: flags > 7 -> flags > 3 (only bits 0-1 are ABI-defined) - Fix TestRTTIRizin skip check to call Rizin.is_installed() as a class method, avoiding a FileNotFoundError before make_cpp runs - Assert make returncode in make_cpp fixture for a clear failure message Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
Binja broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code