Skip to content

Extend PSR income types for FRV#165

Open
GitGuru7 wants to merge 3 commits into
developfrom
feat/vpd-774
Open

Extend PSR income types for FRV#165
GitGuru7 wants to merge 3 commits into
developfrom
feat/vpd-774

Conversation

@GitGuru7
Copy link
Copy Markdown
Contributor

Description

Resolves #

@GitGuru7 GitGuru7 self-assigned this May 21, 2026
fred-venus
fred-venus previously approved these changes May 25, 2026
@fred-venus
Copy link
Copy Markdown
Contributor

fred-venus commented May 25, 2026

we will need an implementation upgrade here, is it ? otherwise iirc its gonna revert if we pass in the new enum value

@GitGuru7
Copy link
Copy Markdown
Contributor Author

we will need an implementation upgrade here, is it ? otherwise iirc its gonna revert if we pass in the new enum value

yes will, include in the same VIP

Debugger022
Debugger022 previously approved these changes May 25, 2026
@fred-venus
Copy link
Copy Markdown
Contributor

fred-venus commented May 25, 2026

we will need an implementation upgrade here, is it ? otherwise iirc its gonna revert if we pass in the new enum value

yes will, include in the same VIP

do u plan to deloy the impl in the same pr or prepare in another pr, if latter can directly merge this

@GitGuru7
Copy link
Copy Markdown
Contributor Author

we will need an implementation upgrade here, is it ? otherwise iirc its gonna revert if we pass in the new enum value

yes will, include in the same VIP

do u plan to deloy the impl in the same pr or prepare in another pr, if latter can directly merge this

Would prefer to include this here in the same PR itself once we have the Cantina report. Will merge it together when the VIP is proposed alongside the main PR.

@GitGuru7 GitGuru7 dismissed stale reviews from Debugger022 and fred-venus via 3722017 May 27, 2026 07:26
@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
Interfaces 100% 100%
ProtocolReserve 95% 78%
Test 100% 100%
Test.Mocks 65% 44%
TokenConverter 89% 74%
Utils 100% 100%
Summary 89% (696 / 782) 75% (243 / 326)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants