Add no_bat_spawn behavior pack - #12
Merged
Merged
Conversation
Data-driven spawn_rules override with an empty conditions array, replacing vanilla's minecraft:bat spawn rules so bats never spawn naturally. No script module needed, unlike silk_touch_drop. Spawn eggs, /summon, and monster spawners are untouched by design. Update README.md and AGENTS.md for the two-pack repo.
Add scripts/validate_packs.py to check manifest schema, UUID validity/uniqueness across all packs, and spawn_rules structure. Generalize CI's JSON/JS syntax checks to cover all tracked files instead of only silk_touch_drop, so no_bat_spawn and future packs are covered automatically.
package.json declared "packageManager": "bun@*", which setup-bun@v2
rejects outright ("Invalid argument not valid semver ('*' received)"),
failing both the test and pre-commit jobs before any steps run. Drop
the field so setup-bun falls back to installing latest bun.
The "increase-if-necessary value was missing its closing quote, breaking YAML parsing entirely (check-yaml pre-commit hook and pre-commit.ci both failed on it). Pre-existing bug from PR #11, unrelated to the pack-validation changes in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data-driven spawn_rules override with an empty conditions array,
replacing vanilla's minecraft:bat spawn rules so bats never spawn
naturally. No script module needed, unlike silk_touch_drop. Spawn
eggs, /summon, and monster spawners are untouched by design.
Update README.md and AGENTS.md for the two-pack repo.## Summary
Type of Change
Related Issues
Test Plan
Checklist
Screenshots / Recordings
Pre-Merge Checklist
Reviewer Notes