Skip to content

Revert backend performance optimisations#172

Closed
smccooey-r7 wants to merge 1 commit into
Velocidex:masterfrom
smccooey-r7:rollback-server-optimisations
Closed

Revert backend performance optimisations#172
smccooey-r7 wants to merge 1 commit into
Velocidex:masterfrom
smccooey-r7:rollback-server-optimisations

Conversation

@smccooey-r7

Copy link
Copy Markdown
Collaborator

Reverting performance optimisation changes, we encountered edge cases with the changes causing errors that we currently don't have time to debug

Removing the changes from master to unblock updates required for other parts of the code base

@scudette

Copy link
Copy Markdown
Contributor

Rather than revert it and if you don't have time to debug the issues maybe it's better for you to just create a branch and use that instead?

@smccooey-r7

Copy link
Copy Markdown
Collaborator Author

Rather than revert it and if you don't have time to debug the issues maybe it's better for you to just create a branch and use that instead?

can do, i wanted the changes to be more official than just building off my personal fork of this repo

don't believe i have any form of write perms for this project so may need you to raise the branch for me in the repo


alternatively, we could pull the performance changes into a separate branch and continue using master as the source of truth for the parent project?

I'm fine with either

@scudette

Copy link
Copy Markdown
Contributor

I would rather actually fix the issues if there are any rather than revert them. If you just want to go back to a specific commit you can just track that commit otherwise a fork would be better for management as you can freely commit any fixed and we can merge them later.

Maybe do the fork in a different GitHub org?

@smccooey-r7

Copy link
Copy Markdown
Collaborator Author

that's acceptable to me, i'll close this PR then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants