Dash pattern#159
Merged
Merged
Conversation
Add a stroke style module that validates PDF dash arrays, normalizes odd interval counts, and stores dash state in the canvas graphics state. Thread stroke style through CanvasBackend and RecordingCanvas so offscreen rendering and replay preserve dash patterns. Apply both the d operator and ExtGState D entries through the same setter. Render dashed strokes in the Skia backend with a dash path effect, while keeping the FemtoVG backend wired for the new trait shape. Co-authored-by: Codex <codex@openai.com>
Move DashPattern into pdf-graphics and re-export it from the crate root so canvas and page parsing share the same typed dash state. Validate dash operands once in pdf-graphics, map those failures at crate boundaries, and keep empty dash arrays as the solid-stroke case instead of storing a sentinel. Update pdf-page ExtGState parsing and pdf-canvas graphics-state application to use the typed DashPattern payload directly, while preserving stroke-style recording and replay behavior. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.