pdf-parser: recover streams with missing /Length#155
Merged
Conversation
Restore Dictionary::get_or_err to return the normal missing-key error instead of panicking, so malformed PDFs continue through standard error propagation. Split stream parsing so declared /Length keeps the exact-read path and wrong-length recovery, while missing /Length now scans for a valid endstream terminator, trims the trailing EOL, and fails when no terminator can be recovered. Add parser and reader regressions for the missing-length recovery path, the no-endstream failure case, and the issue1293r.pdf load case. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore Dictionary::get_or_err to return the normal missing-key error instead of panicking, so malformed PDFs continue through standard error propagation.
Split stream parsing so declared /Length keeps the exact-read path and wrong-length recovery, while missing /Length now scans for a valid endstream terminator, trims the trailing EOL, and fails when no terminator can be recovered.
Add parser and reader regressions for the missing-length recovery path, the no-endstream failure case, and the issue1293r.pdf load case.