Cs refactor#154
Merged
Merged
Conversation
Move operator definitions, dispatch, backend traits, and recording support into a dedicated pdf-content-stream-operators crate. This keeps the shared operator surface independent from the content stream parser and materialization code. Keep pdf-content-stream focused on parsing content streams, materializing ContentStream values, and allocating content stream IDs. Update pdf-canvas, pdf-page, pdf-font, and related dependencies to use the new operator crate and the new pdf-content-stream reexports, and drop stale direct dependencies where they are no longer needed. Co-authored-by: Codex <codex@openai.com>
Move content-stream parsing entrypoints off the crate root and into ContentStream constructors. Keep the operator parser internals private, update downstream call sites, and add direct coverage for array concatenation and the documented constructor behavior. Co-authored-by: Codex <codex@openai.com>
Refactor ContentStream to accept resolved ObjectVariant values and parse single streams or /Contents arrays directly without concatenating decoded bytes first. Keep allocator-backed IDs unchanged and allocate only after parsing succeeds. Update the page, form, pattern, XObject, Type3 font, and canvas call sites to use the new constructor, and refresh parser API tests for array resolution, failure handling, and monotonic IDs. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.