Skip to content

CANON-041: replace 100vh with 100dvh in Studio Hub sidebar #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VaultSparkStudios wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CANON-041: replace 100vh with 100dvh in Studio Hub sidebar #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions studio-hub/src/styles/hub.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ body {
radial-gradient(circle at 85% 10%, rgba(122, 231, 199, 0.12), transparent 22%),
radial-gradient(circle at 50% 100%, rgba(255, 200, 116, 0.07), transparent 26%),
linear-gradient(145deg, #04070d 0%, #07111d 45%, #03060a 100%);
min-height: 100vh;
min-height: 100dvh;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore 100vh fallbacks before 100dvh

In browsers that do not support dynamic viewport units, this 100dvh declaration is ignored; the same commit keeps a 100vh fallback for the mobile sidebar, but the body, #app, .shell, and desktop .sidebar replacements no longer have one. On older Safari/embedded webviews the hub can therefore lose its full-viewport shell and scrollable/sticky sidebar behavior that previously worked with 100vh. Keep the old 100vh declaration immediately before the 100dvh override for these non-mobile rules as well.

Useful? React with 👍 / 👎.

}

body::before {
Expand All @@ -53,12 +53,12 @@ button { font: inherit; cursor: pointer; border: none; background: none; }
a { color: inherit; text-decoration: none; }

/* ── LAYOUT ── */
#app { min-height: 100vh; position: relative; z-index: 1; }
#app { min-height: 100dvh; position: relative; z-index: 1; }

.shell {
display: grid;
grid-template-columns: var(--sidebar-w) minmax(0, 1fr);
min-height: 100vh;
min-height: 100dvh;
}

/* ── SIDEBAR ── */
Expand All @@ -70,7 +70,7 @@ a { color: inherit; text-decoration: none; }
flex-direction: column;
position: sticky;
top: 0;
height: 100vh;
height: 100dvh;
overflow-y: auto;
}

Expand Down Expand Up @@ -947,11 +947,13 @@ body.theme-light .issue-item { background: var(--panel-2); }
top: 0;
left: 0;
width: 270px;
height: 100vh;
height: 100vh; /* fallback for browsers without dvh support */
height: 100dvh;
z-index: 100;
box-shadow: 4px 0 24px rgba(0,0,0,0.4);
padding-top: env(safe-area-inset-top, 24px);
padding-left: env(safe-area-inset-left, 0);
padding-bottom: env(safe-area-inset-bottom, 0);
}

.shell.mobile-nav-open .sidebar {
Expand Down
Loading