CANON-041: command-palette mobile height — 100vh → 100dvh + safe-area inset#51
Open
VaultSparkStudios wants to merge 1 commit into
Open
CANON-041: command-palette mobile height — 100vh → 100dvh + safe-area inset#51VaultSparkStudios wants to merge 1 commit into
VaultSparkStudios wants to merge 1 commit into
Conversation
…area On iOS Safari, `100vh` equals the large viewport (address bar collapsed), so the full-screen command palette overflows the visible area when the address bar is shown. `100dvh` tracks the actual visible viewport. Added `padding-bottom: env(safe-area-inset-bottom, 0px)` so the results list is never clipped behind the home indicator on notchless iPhones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix a CANON-041 violation in the command palette's mobile CSS:
height:100vh→height:100dvh, and addpadding-bottom: env(safe-area-inset-bottom, 0px).File:
assets/command-palette.jsline 96 (inlineSTYLEstring,@media (max-width: 720px)block)Why this is release-blocking
On iOS Safari,
100vhresolves to the large viewport height (address bar fully collapsed). When the address bar is visible/expanded, the palette is taller than the actual visible area — the bottom of the results list is cut off and unreachable.100dvh(dynamic viewport height) always equals the currently-visible area regardless of toolbar state.The missing
env(safe-area-inset-bottom, 0px)padding means the bottom results row renders beneath the home indicator on iPhones without a physical home button (iPhone X+).What to verify on device
Generated by Claude Code