CANON-041: fix investor-admin access-denied screen — 100vh → 100dvh#41
Open
VaultSparkStudios wants to merge 1 commit into
Open
CANON-041: fix investor-admin access-denied screen — 100vh → 100dvh#41VaultSparkStudios wants to merge 1 commit into
VaultSparkStudios wants to merge 1 commit into
Conversation
The access-denied fallback screen rendered via investor-admin.js used `min-height:100vh` (layout viewport, static) as an inline style. On iOS Safari, 100vh includes the area behind the browser toolbar, so the screen slightly overflows the visual viewport when the chrome is visible. Swapping to `min-height:100dvh` anchors to the dynamic viewport which tracks what is actually visible to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Single-line CANON-041 fix in
assets/investor-admin.js: the access-denied fallback screen usedmin-height:100vh(layout viewport, static) as an inline style. On iOS Safari,100vhincludes the area behind the browser toolbar, so the centered "Access denied" message could be pushed above the visible viewport fold when the chrome is visible. Replaced withmin-height:100dvhwhich tracks the dynamic (visual) viewport.File changed:
assets/investor-admin.js:408Context
This was the last remaining
100vhusage in the codebase not already covered by an open PR. All other CANON-041 issues found during this audit (nav-sheet60vh, command palette100vh, studio-hub sidebar, investor portal mobile nav) already have dedicated open PRs in review.How to verify on mobile
🤖 Routine CANON-041 audit — automated PR, do not merge without founder review.
Generated by Claude Code