refactor: replace sys.exit() with SessionError, 44 new tests#5
Merged
Conversation
- db.py: resolve_session_id, get_session_info, get_latest_session raise SessionError instead of sys.exit(1) - All 7 command files catch SessionError and return exit code 1 - New tests: get_messages (12), format_part_to_md (17), prune (10), SessionError (4), resolve_session_id (1) - Total: 159 tests (+38%), all passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Красные пункты:\n- db.py: resolve_session_id, get_session_info, get_latest_session теперь raise SessionError вместо sys.exit\n- Все команды ловят SessionError и возвращают 1\n- 44 новых теста (159 total, +38%)\n- Тесты: get_messages, format_part_to_md, prune, SessionError\n- Version bumped to 0.4.8